• Seth Brenith's avatar
    Revert "Move branch inversion on ==0 into platform-agnostic reducer" · 252acd7f
    Seth Brenith authored
    This reverts commit 0c72c719.
    
    Reason for revert: Wasm code size increase because not all pipelines use CommonOperatorReducer
    
    Original change's description:
    > Move branch inversion on ==0 into platform-agnostic reducer
    > 
    > This change is based on a discussion from
    > https://crrev.com/c/v8/v8/+/2053769/4/src/compiler/machine-operator-reducer.cc#1696
    > wherein Tobias suggested moving the folding away of ==0 operations out
    > of the platform-specific instruction selectors and into the
    > MachineOperatorReducer. I noticed that CommonOperatorReducer already
    > handles some very similar cases, so I have tried putting the ==0 folding
    > into CommonOperatorReducer instead. I'm happy to move it into
    > MachineOperatorReducer if that's better; I still don't have a very good
    > understanding of how roles are separated among reducers.
    > 
    > Change-Id: Ia0285bd9fafeef29d87cc88654bd6d355d467e8f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2076498
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66688}
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:1061767
    Change-Id: Id1fdfb38357eb514d92ed3be0a683f077202faa4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2117789
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66862}
    252acd7f
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...