• adamk's avatar
    Use Scope::function_kind_ to distinguish arrow function scopes · 24565b85
    adamk authored
    Previously, arrow function scopes had a separate ScopeType. However,
    Scope::DeserializeScopeChain() erroneously deserialized ARROW_SCOPE
    ScopeInfos as FUNCTION_SCOPE. This could lead to bugs such as the
    attached one, where "super" was disallowed where it should have
    been allowed.
    
    This patch utilizes the Scope's FunctionKind to distinguish arrow
    functions from others. Besides fixing the above bug, this also
    simplifies code in various places that had to deal with two different
    ScopeTypes both of which meant "function".
    
    BUG=v8:4466
    LOG=n
    
    Review URL: https://codereview.chromium.org/1386253002
    
    Cr-Commit-Position: refs/heads/master@{#31154}
    24565b85
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...