• adamk's avatar
    Optimize add/set/delete operations for string keys in Maps and Sets · 243764b0
    adamk authored
    This was previously landed in commit 8599f5f0, but failed the
    collections mjsunit test on ia32 with --deopt-every-n=1. The fixed
    patch adds a ClearFlag(HValue::kCanOverflow) call after every
    arithmetic operation, which should remove all the deopt points in these
    intrinsics.
    
    Ideally, it seems like there should be a way to verify that there are
    no deopt points for these inline optimized functions, since there's
    nothing to deopt to. But I don't currently know of such a thing.
    
    Review URL: https://codereview.chromium.org/782073002
    
    Cr-Commit-Position: refs/heads/master@{#25715}
    243764b0
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...