• bmeurer's avatar
    Revert of [turbofan] Splinter into one range. (patchset #2 id:80001 of... · 23a8837f
    bmeurer authored
    Revert of [turbofan] Splinter into one range. (patchset #2 id:80001 of https://codereview.chromium.org/1391023007/ )
    
    Reason for revert:
    Weird endless loop in TopLevelLiveRange::Merge() due to always splitting first and not making progress. See comments, unfortunately no useable repro.
    
    Original issue's description:
    > [turbofan] Splinter into one range.
    >
    > Before this CL, we created one live range per successive set of
    > deferred blocks. For scenarios with many such blocks, this creates
    > an upfront pressure for the register allocator to deal with many ranges.
    > Linear sorts ranges, which is a super-linear operation.
    >
    > The change places all deferred intervals into one range, meaning that,
    > at most, there will be twice as many live ranges as the original set. In
    > pathological cases (benchmarks/Compile/slow_nbody1.js), this change
    > halves the compilation time. We see some improvements elsewhere,
    > notably SQLite at ~4-5%.
    >
    > We may be able to avoid the subsequent merge. Its cost is the
    > additional ranges it may need to create. The sole reason for the merge
    > phase is to provide an unchanged view of the world to the subsequent
    > phases. With the at-most-one splinter model, we may be able to teach
    > the other phases about splintering - should we find perf hindrances
    > due to merging.
    >
    > Committed: https://crrev.com/efdcd20267870276c5824f1ccf4e171ac378f7ae
    > Cr-Commit-Position: refs/heads/master@{#31224}
    
    TBR=jarin@chromium.org,mtrofin@google.com,mtrofin@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review URL: https://codereview.chromium.org/1403163003
    
    Cr-Commit-Position: refs/heads/master@{#31300}
    23a8837f
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
x64 Loading commit data...
bytecode-graph-builder-unittest.cc Loading commit data...
change-lowering-unittest.cc Loading commit data...
coalesced-live-ranges-unittest.cc Loading commit data...
common-operator-reducer-unittest.cc Loading commit data...
common-operator-unittest.cc Loading commit data...
compiler-test-utils.h Loading commit data...
control-equivalence-unittest.cc Loading commit data...
control-flow-optimizer-unittest.cc Loading commit data...
dead-code-elimination-unittest.cc Loading commit data...
diamond-unittest.cc Loading commit data...
graph-reducer-unittest.cc Loading commit data...
graph-reducer-unittest.h Loading commit data...
graph-trimmer-unittest.cc Loading commit data...
graph-unittest.cc Loading commit data...
graph-unittest.h Loading commit data...
instruction-selector-unittest.cc Loading commit data...
instruction-selector-unittest.h Loading commit data...
instruction-sequence-unittest.cc Loading commit data...
instruction-sequence-unittest.h Loading commit data...
interpreter-assembler-unittest.cc Loading commit data...
interpreter-assembler-unittest.h Loading commit data...
js-builtin-reducer-unittest.cc Loading commit data...
js-context-relaxation-unittest.cc Loading commit data...
js-intrinsic-lowering-unittest.cc Loading commit data...
js-operator-unittest.cc Loading commit data...
js-type-feedback-unittest.cc Loading commit data...
js-typed-lowering-unittest.cc Loading commit data...
linkage-tail-call-unittest.cc Loading commit data...
live-range-builder.h Loading commit data...
live-range-unittest.cc Loading commit data...
liveness-analyzer-unittest.cc Loading commit data...
load-elimination-unittest.cc Loading commit data...
loop-peeling-unittest.cc Loading commit data...
machine-operator-reducer-unittest.cc Loading commit data...
machine-operator-unittest.cc Loading commit data...
move-optimizer-unittest.cc Loading commit data...
node-cache-unittest.cc Loading commit data...
node-matchers-unittest.cc Loading commit data...
node-properties-unittest.cc Loading commit data...
node-test-utils.cc Loading commit data...
node-test-utils.h Loading commit data...
node-unittest.cc Loading commit data...
opcodes-unittest.cc Loading commit data...
register-allocator-unittest.cc Loading commit data...
schedule-unittest.cc Loading commit data...
scheduler-unittest.cc Loading commit data...
select-lowering-unittest.cc Loading commit data...
simplified-operator-reducer-unittest.cc Loading commit data...
simplified-operator-unittest.cc Loading commit data...
state-values-utils-unittest.cc Loading commit data...
tail-call-optimization-unittest.cc Loading commit data...
typer-unittest.cc Loading commit data...
value-numbering-reducer-unittest.cc Loading commit data...
zone-pool-unittest.cc Loading commit data...