• Jakob Gruber's avatar
    Clamp properly in the String.p.indexOf reduction · 232bf1ff
    Jakob Gruber authored
    This fixes a bug introduced in crrev.com/c/2660995.
    String.prototype.indexOf must clamp the `position` argument as per
    step:
    
      7. Let start be the result of clamping pos between 0 and len.
    
    Source: tc39.es/ecma262/#sec-string.prototype.indexof
    
    Previously, this was done in the StringIndexOf builtin, but the recent
    refactor changed builtin implementations to match the spec more
    closely (i.e. to clamp in String.prototype.indexOf, not
    StringIndexOf). This means we now have to clamp in
    JSCallReducer::ReduceStringPrototypeIndexOf.
    
    Tbr: neis@chromium.org
    Bug: chromium:1194869
    Change-Id: I5af8d41b50f4905453f03079e3ee6d46186536db
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2799359Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73772}
    232bf1ff
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...