• Clemens Hammacher's avatar
    [wasm] Fix deadlock in async compilation · 231a96bb
    Clemens Hammacher authored
    This fixes a deadlock related to throttling: It can happen that all
    background tasks detect that they should not produce more work because
    of throttling (!CanAcceptWork()). Reducing the number of running
    background tasks is done in a later step (OnBackgroundTaskStopped).
    If the finisher task finishes all outstanding units between these two
    calls, it will not schedule another background compilation task, but
    all background compilation tasks will quit, hence compilation will
    never finish.
    
    Fixing this should allow us to reenable the 'wasm-finish-compilation'
    test: https://crrev.com/c/999632
    
    R=ahaas@chromium.org
    
    Bug: chromium:824681
    Change-Id: I967e4d6b2917d369dd49bb80ce4bef552d10b371
    Reviewed-on: https://chromium-review.googlesource.com/1002174
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52483}
    231a96bb
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...