• vogelheim's avatar
    Fix DCHECK on SetBookmark. · 21e6831e
    vogelheim authored
    The DCHECK was a lie. The idea was that - when a bookmark is set -
    the scanner must clearly be at a character boundary and hence the
    bookmark does not need to save a 'partial' UTF-8 code point. The
    first part is true - the Scanner is always at a character boundary -
    but the 'partial' UTF-8 code point is at the end of a block, not at
    the current character position of the Scanner.
    Hence, the 'partial' character needs to be saved as well.
    
    jkummerow: Thanks for noticing.
    
    BUG=chromium:470930
    R=jochen@chromium.org, jkummerow@chromium.org
    LOG=N
    
    Review URL: https://codereview.chromium.org/1154773004
    
    Cr-Commit-Position: refs/heads/master@{#28661}
    21e6831e
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...