• Suraj Sharma's avatar
    Modify the DCheck to avoid failures. · 2174ba9f
    Suraj Sharma authored
    Now since we also encode KeyedAccessStoreMode information in the slow
    handler for some cases, the DCheck can result in failure.The Check can
    result in failures for other cases of StoreSlow. Removing the DCHECK
    altogether, now verifying the correctness of the behavior using the
    Kind Bits of the Handler in the method GetKeyedAccessStoreMode.
    
    
    Bug: chromium:1027025, chromium:1028085
    Change-Id: I59acedbb499930e67ae5999d4bfd0f040a34b46e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1929408Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Suraj Sharma <surshar@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#65185}
    2174ba9f
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...