• bmeurer's avatar
    [turbofan] Use unreliable LOAD_IC feedback for Array.prototype.push. · 1fceaf9f
    bmeurer authored
    Add the notion of reliable vs. unreliable receiver map information to
    the NodeProperties::InferReceiverMaps machinery. The information is
    considered reliable here if the maps are known to be valid based on the
    effect chain, and unreliable if there was a side-effect in between that
    might have changed the receiver map.
    
    Use this unreliable information for Array.prototype.push, guarded by
    either stability dependencies or map checks, which might present a
    potential deoptimization loop, which is very unlikely, but still needs
    fixing in the future. This is important to optimize calls to push even
    in cases like this
    
      array.push(something.func());
    
    where we have a side-effect (the call to something.func) between the
    load of array.push and the actual call.
    
    R=jarin@chromium.org
    BUG=v8:5267,v8:6241
    
    Review-Url: https://codereview.chromium.org/2812233002
    Cr-Commit-Position: refs/heads/master@{#44595}
    1fceaf9f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...