• Leszek Swirski's avatar
    [destructuring] Elide coercible check for simple keys · 1fba0441
    Leszek Swirski authored
    Simple object destructuring, such as `let {a,b} = o`, is less efficient
    than the equivalent assignments `let a = o.a; let b = o.b`. This is
    because it does a nil check of `o` before the assignments. However, this
    nil check is not strictly necessary for simple (i.e. non-computed) names,
    as there will be an equivalent nil check on the first access to o in
    `o.a`. For computed names the computation is unfortunately obervable.
    
    So, we can elide the nil check when the first property (if any) of the
    destructuring target is a non-computed name. This messes a bit with our
    error messages, so we re-use the CallPrinter to also find destructuring
    assignment based errors, and fiddle with the error message there. As
    a side-effect, we also get out the object name in the AST, so we can
    output a slightly nicer error message.
    
    Change-Id: Iafa858e27ed771a146cd3ba57903cc73bb46951d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1773254Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63453}
    1fba0441
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...