• Mythri A's avatar
    [handles] Fix is_identical_to to correctly work with Smis · 1f858b3f
    Mythri A authored
    HandleBase::is_identical_to() is_identical_to in handle base is used to
    do the exact comparison by just comparing the locations. When the
    locations are different the values are compared. For Smis it
    compares 64 bits which might lead to incorrect behaviour. Smis loaded as
    a TaggedField has the root address added. It is expexted that we don't
    use higher order bits on Smi. Hence, is_identical_to shouldn't use these
    bits when comparing Smis. This cl fixes it by comparing the objects
    created from the given location. That takes care of correctly comparing
    the required bits.
    
    Change-Id: I574dfbea4c1fffc7a9e3a6a10ad7631d40c518ce
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2461743
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70422}
    1f858b3f
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...