• thakis's avatar
    Fix C++ violation. · 1f7a7b32
    thakis authored
    gcc rejects the following snippet, clang rejects it in -std=c++11 mode:
      namespace A { template<class T> class C {}; }
      namespace B { template class A::C<int>; }
    
    Indeed, the C++ standard says in 14.7.2p2 "An explicit instantiation shall
    appear in an enclosing namespace of its template", so cl.exe is incorrect to
    allow this.
    
    Just move the instantiation out of the v8 namespace to fix.  No intended
    behavior change.  Fixes building with clang-cl on Windows.
    
    BUG=chromium:475643
    LOG=N
    TBR=svenpanne@chromium.org
    
    Review URL: https://codereview.chromium.org/1073903002
    
    Cr-Commit-Position: refs/heads/master@{#27721}
    1f7a7b32
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...