• Jakob Gruber's avatar
    [regexp] Use the correct native context for the regexp species protector · 1e88fece
    Jakob Gruber authored
    The regexp species protector was recently moved from the isolate onto
    the native context to avoid cross-context pollution of the regexp fast
    path state.
    
    The implementation was incomplete. We unconditionally used the isolate's
    current native context, but it is possible for the object we are looking
    at to come from a different context (= its creation context).
    
    The fix is two-fold. 1. when speed is not too important (e.g. when
    invalidating the protector), grab the creation context off the object.
    2. in the regexp fast path check, just document how our current solution
    is sufficient: although we may initially look at the wrong protector
    cell, we'd later bail out when comparing the object's map against the
    initial regexp map (stored on the current native context).
    
    Bug: v8:9463
    Change-Id: I653732b573f2dd456b3c6b723653dcacf9ead591
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776078
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63520}
    1e88fece
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...