• Jakob Gruber's avatar
    [regexp] Use the correct native context for the regexp species protector · 1e88fece
    Jakob Gruber authored
    The regexp species protector was recently moved from the isolate onto
    the native context to avoid cross-context pollution of the regexp fast
    path state.
    
    The implementation was incomplete. We unconditionally used the isolate's
    current native context, but it is possible for the object we are looking
    at to come from a different context (= its creation context).
    
    The fix is two-fold. 1. when speed is not too important (e.g. when
    invalidating the protector), grab the creation context off the object.
    2. in the regexp fast path check, just document how our current solution
    is sufficient: although we may initially look at the wrong protector
    cell, we'd later bail out when comparing the object's map against the
    initial regexp map (stored on the current native context).
    
    Bug: v8:9463
    Change-Id: I653732b573f2dd456b3c6b723653dcacf9ead591
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776078
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63520}
    1e88fece
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...