• Clemens Backes's avatar
    [wasm] Always clear "thread in wasm flag" in runtime functions · 1e6669a7
    Clemens Backes authored
    From several runtime functions, this was still missing. For some, it
    shouldn't really matter, but some runtime functions (e.g. DebugBreak)
    can call back into JS to wasm, and there it matters.
    
    As it never hurts to clear and re-set the flag, this CL consistently
    resets the flag for all runtime functions called from wasm code. For
    runtime functions that are called from outside of wasm (e.g. from
    wrappers), we add a DCHECK instead that the flag is not set. There is
    one exception (WasmThrowTypeError), which is called both from wasm code
    and from wrappers. In this case it's OK, I added a comment saying why.
    
    Drive-by: Remove obsolete comments (from a time where this clearing
    was still optional in some cases).
    
    R=ahaas@chromium.org
    
    Bug: v8:10389
    Change-Id: Id4ec92a42e89005276b42c145fe3572eb459d220
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157026Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67274}
    1e6669a7
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...