• Jakob Gruber's avatar
    [compiler] Track the maximal unoptimized frame size · 1e472c42
    Jakob Gruber authored
    This is another step towards considering the unoptimized frame size in
    stack checks within optimized code.
    
    With the changes in this CL, we now keep track of the maximal
    unoptimized frame size of the function that is currently being
    compiled. An optimized function may inline multiple unoptimized
    functions, so a single optimized frame can deopt to multiple
    frames. The real frame size thus differs in different parts of the
    optimized function.
    
    We only care about the maximal frame size, which we calculate
    conservatively as an over-approximation, and track in
    InstructionSelector::max_unoptimized_frame_height_ for now. In future
    work, this value will be passed on to codegen, where it will be
    applied as an offset to the stack pointer during the stack check.
    
    (The motivation behind this is to avoid stack overflows through deopts,
    caused by size differences between optimized and unoptimized frames.)
    
    Note that this offset only ensure that the topmost optimized frame can
    deopt without overflowing the stack limit. That's fine, because we only
    deopt optimized frames one at a time. Other (non-topmost) frames are
    only deoptimized once they are returned to.
    
    Drive-by: Print variable and total frame height in --trace-deopt.
    
    Bug: v8:9534
    Change-Id: I821684a9da93bff59c20c8ab226105e7e12d93eb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762024
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63330}
    1e472c42
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...