• Leszek Swirski's avatar
    [parser] Fix reindexing of functions inside classes · 1e37ca26
    Leszek Swirski authored
    A class's fields can appear twice in the class AST, via the properties
    array and the synthetised initializer method. This means that the
    reindexer can end up visiting the same function literal twice, since the
    T in AST is no longer a T but rather a DAG.
    
    Now, we special case the class visitor in the reindexer to avoid these
    double visits where appropriate. We know what kinds of fields can be
    double visisted, so we don't need a visited set, but we now also have
    one for debug builds to verify that each function is visited exactly
    once.
    
    Bug: chromium:974627
    Change-Id: Ib531becc6e3f3c73f420b5fb49790fe4a2022d65
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1667003Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62282}
    1e37ca26
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...