• Jakob Gruber's avatar
    [compiler] Use kAssumeMemoryFence in two critical ref creation spots · 1e2b9c5e
    Jakob Gruber authored
    Using kAssumeMemoryFence works around the fact that the graph stores
    handles (and not refs). The assumption is that any handle inserted
    into the graph is safe to read; but we don't preserve the reason why
    it is safe to read. Thus we must over-approximate here and assume the
    existence of a memory fence.
    
    Note this is only valid if all spots that insert handles into the
    graph ensure that the handle can safely be read.
    
    In the future, we should consider having the graph store ObjectRefs or
    ObjectData pointer instead, which would make new ref construction here
    unnecessary.
    
    Bug: v8:7790,chromium:1209798
    Change-Id: Ic22340ea9f34a24be530a3c62c8309d25e108f3f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2902742Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74653}
    1e2b9c5e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...