• Jakob Gruber's avatar
    [compiler] Use kAssumeMemoryFence in two critical ref creation spots · 1e2b9c5e
    Jakob Gruber authored
    Using kAssumeMemoryFence works around the fact that the graph stores
    handles (and not refs). The assumption is that any handle inserted
    into the graph is safe to read; but we don't preserve the reason why
    it is safe to read. Thus we must over-approximate here and assume the
    existence of a memory fence.
    
    Note this is only valid if all spots that insert handles into the
    graph ensure that the handle can safely be read.
    
    In the future, we should consider having the graph store ObjectRefs or
    ObjectData pointer instead, which would make new ref construction here
    unnecessary.
    
    Bug: v8:7790,chromium:1209798
    Change-Id: Ic22340ea9f34a24be530a3c62c8309d25e108f3f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2902742Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74653}
    1e2b9c5e
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...