• Zhi An Ng's avatar
    [wasm-simd][liftoff][ia32] Fix operands on non-AVX · 236aff1b
    Zhi An Ng authored
    The main fix here is on non-AVX builds, the shifts require dst == src.
    Calling macro-assembler functions like Psrlw assumes that we already
    met that requirement (which we usually specify in TurboFan's
    instruction-selector). On Liftoff, we need to do that check manually.
    This is done by using the helper EmitSimdShiftOpImm which will do this
    check, and dispatches to AVX if supported, or mov if dst != src.
    
    Also fix a couple of places where we forgot to annotate the required SSE
    extension for the instruction.
    
    Bug: v8:11078
    Change-Id: Icc31df9ab80c041f4bb3bd48444658368eaa2c91
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505251Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70889}
    236aff1b
Name
Last commit
Last update
..
liftoff-assembler-ia32.h Loading commit data...