• Anton Bikineev's avatar
    cppgc: Avoid fragmentation in NormalPageMemoryRegion · 1d3a1c6f
    Anton Bikineev authored
    NormalPageMemoryRegion is a span of 10 pages, all of which must belong
    to the same space. This requirement imposes a fragmentation issue for virtual space, which is not ideal for the current 2GB cage
    configuration.
    
    The CL fixes this by mixing pages of different spaces inside the same
    NormalPageMemoryRegion. With cage it's actually not necessary anymore
    to have NormalPageMemoryRegion, but we keep it to allow the code to be
    uniform for cage/non-cage configurations.
    
    There is no type confusion across spaces, since pages (even empty) are
    never shared between spaces. In addition, the shared cage puts an
    additional memory constraint on the GC. So, there is no security benefit
    in having NormalPageMemoryRegion assigned to a single space.
    
    Savings in reserved address space:
    cnn:2021: 14%
    facebook_infinite_scroll:2018: 23%
    
    Bug: chromium:1325007, chromium:1352649
    Change-Id: I7b49032d581dd56feb8633734a1f37803e9526c6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3840749Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Anton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82584}
    1d3a1c6f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...