• Adam Klein's avatar
    [scopes] Clarify and narrow when scopes care about an eval() call · 1c9de0b2
    Adam Klein authored
    There are two reasons for Scopes to need information about eval calls
    inside them:
    
      - Eval in a scope, or any of its inner scopes, turns off a bunch of
        scope analysis optimizations (e.g., all variables have to be treated
        as "used" and context-allocated).
      - Eval in a sloppy declaration scope means allows runtime addition
        of var declarations.
    
    This patch aims to make the code better-reflect this reality.
    It's meant as a pure cleanup, with no expected change in behavior.
    
    Change-Id: I744c5051bb7a90b11420930e9596e5d6c35eb440
    Reviewed-on: https://chromium-review.googlesource.com/602848
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47257}
    1c9de0b2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...