• bmeurer's avatar
    [turbofan] Further optimize spread/apply with arguments/rest parameters. · 1c555714
    bmeurer authored
    Extend the use list check for the arguments object/rest parameters
    during apply/spread optimization to allow for more cases, such that
    even in code like
    
      function foo() {
        if (arguments.length === 1) return arguments[0];
        return bar.apply(this, arguments);
      }
    
    we don't need to materialize the arguments object. This obviously comes
    with a phase ordering problem, which we resolve by introducing a
    waitlist in the JSCallReducer, which contains the nodes that we should
    check again after all the other reductions are done, and which might
    then be reducible. This is not 100% ideal, but get's us closer to where
    we want to be, and it's crucial to speed up Node core, especially the
    event emitter.
    
    BUG=v8:4551,v8:5511, v8:5726
    R=petermarshall@chromium.org
    
    Review-Url: https://codereview.chromium.org/2956233002
    Cr-Commit-Position: refs/heads/master@{#46337}
    1c555714
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...