• jameslahm's avatar
    [compiler] Fix inducing variable in LoopVariableOptimizer · 1b999119
    jameslahm authored
    In JSCallReducer::ReduceArrayPrototypeShift, when disable
    FLAG_turbo_loop_variable, typer cannot infer loop phi variable
    is in [1, kMaxCopyElements-1], and will break in representing
    kRepFloat64 (Range(1, inf)) to kRepWord64 when converting
    input for kLoadElement. So we need to add type guard for loop
    variable. And we need to use loop phi variable when using
    NumberLessThan to check terminate and updating phi loop variable,
    otherwise which will break inducing variables in LoopVariableOptimizer.
    
    Bug: v8:12632, chromium:1308241, chromium:1308029, chromium:1308087
    Change-Id: I9f96e696f1103f39e633890b17b87bfb28b1dbc4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3546577Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79695}
    1b999119
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...