• Shu-yu Guo's avatar
    Remove per-parameter position var scope · 1b450a17
    Shu-yu Guo authored
    The spec was normatively changed to simplify var scopes for parameter
    expressions. Previously there was a per-parameter var scope in sloppy
    mode so direct evals could introduce vars that did not escape the
    parameter position. That semantics is complex both for the programmer
    and implementation and has resulted in bugs in the past. Furthermore, it
    has never been fully interoperable (with Safari in particular). The spec
    was instead changed to be simpler: to have a single var scope for
    sloppy evals in parameters that encloses the parameter scope and body
    scope.
    
    This simplification lets us remove expression-scope-reparenter.
    
    Drive-by removal of stale reference to PatternRewriter.
    
    Bug: v8:7532
    Change-Id: Iade5594abe0009f7f3f6a1adad18628b17e1e779
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962471Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65517}
    1b450a17
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...