• Dominik Inführ's avatar
    [compiler] Always use full version of RecordWrite builtin · 1b437aa8
    Dominik Inführ authored
    When we know that the value in a write barrier is a map, we know that
    we are not going to have an old-to-new reference (maps are always in
    old generation). Therefore we also don't really need the generational
    barrier in RecordWrite. While this is technically correct, we don't
    gain much from this optimization. The inline and out-of-line generated
    code for the barrier is still the same as in all other cases. Which
    means that outside marking we don't even reach the RecordWrite builtin.
    Most write barrier executions happen outside incremental marking, hence
    performance of the incremental marking barrier isn't critical. This CL
    always uses the full RecordWrite builtin using a flag in order to
    allow for an easy revert.
    
    This CL is motivated by the shared heap work, which needs an additional
    always-on barrier in the future (similar to OLD_TO_NEW) to keep a
    OLD_TO_SHARED remembered set up-to-date. While maps are always in the
    old generation, they maybe by located in the shared heap.
    
    Bug: v8:11708
    Change-Id: I71a6ded2547a0b2bbb9bbbd796dbcae0987b2232
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471854Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79160}
    1b437aa8
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...