• Adam Klein's avatar
    [parser] Remove inlining of Parser::RewriteSpreads · 1abeb0ca
    Adam Klein authored
    Despite the V8_INLINE annotation, it was never actually inlined until
    18cac20c removed the NonPatternRewriter,
    causing all calls to Parser::RewriteNonPattern() to inline RewriteSpreads.
    
    This patch should recover the binary bloat in the attached bug while
    retaining the inlining of the rest of RewriteNonPattern, which in
    the common case does very little work (and doesn't call out to RewriteSpreads).
    
    Bug: chromium:784924
    Change-Id: I1c2062b41ceb51a9522d49bdb9353e1840393ca1
    Reviewed-on: https://chromium-review.googlesource.com/769442Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49370}
    1abeb0ca
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...