• Clemens Backes's avatar
    [liftoff] Materialize constants before conditional branches · 1a911e6c
    Clemens Backes authored
    The number of constants stored in locals and the merge region can be
    arbitrarily big, thus generating arbitrarily long code for a single
    `br_if`. This happened in particular for unoptimized code.
    
    This CL solves this by materializing all constants (in registers or on
    the stack) before doing a conditional branch. This ensures that in a
    series of `br_if`s, each constant is only spilled once instead of on
    each single branch.
    
    For the linked bug, this reduces the total generated code size by ~36%.
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1117033
    Change-Id: I84ea2ea9ba4d3de9b042ceb223af15c3d73dc5b8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2364498Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69485}
    1a911e6c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...