-
Joshua Litt authored
This reverts commit d4574d18. Reason for revert: In addition to the earlier octane regression, this cl also created a regression in desktop browsing Bug: chromium:1019601 Original change's description: > Reland "[regexp] Clone match info for match indices." > > This reverts commit d7793c06. > > Reason for revert: This cl *will* cause regexp regressions. We are trying to gauge the real world impact. > > Original change's description: > > Revert "[regexp] Clone match info for match indices." > > > > This reverts commit dfd9ceb9. > > > > Reason for revert: Regressions https://chromeperf.appspot.com/group_report?rev=64356 https://crbug.com/1015749 > > > > Original change's description: > > > [regexp] Clone match info for match indices. > > > > > > The current behavior for generating match indices simply stashes a > > > pointer to the match info and then constructs the indices lazily. > > > However, it turns out the match info object used to create the result > > > object is the regexp_last_match_info living on native context, and thus > > > it can change between the creation of the result object and the generation > > > of indices. This cl clones the match info which will be safer. > > > > > > Bug: v8:9548 > > > Change-Id: Ia6f26f88fbc22fd09671bf4c579d39a1510b552d > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864585 > > > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#64356} > > > > TBR=jgruber@chromium.org,joshualitt@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: v8:9548, chromium:1015749 > > Change-Id: I9c30b8fb459cf2aa89d920bf061614441250844d > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870236 > > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#64407} > > TBR=jgruber@chromium.org,joshualitt@chromium.org > > > Bug: v8:9548, chromium:1015749 > Change-Id: I151511307e3d8752fdbde4b8247514031b141b08 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1879587 > Reviewed-by: Joshua Litt <joshualitt@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64587} TBR=jgruber@chromium.org,joshualitt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9548, chromium:1015749 Change-Id: Ie5a8e55338728aae33102d82e60a188f6440e8f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1898030Reviewed-by: Joshua Litt <joshualitt@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#64749}
1a6ffffb