• Clemens Backes's avatar
    [Liftoff] Clean up implementation of AtomicStore · d8bb229d
    Clemens Backes authored
    As discussed offline, the current implementation implement each
    situation separately. I think we can simplify the code a lot by sharing
    code between the different paths.
    This CL does that by
    1) implementing the kI64Store case separately, because it does not have
       all the register contraints that the others have, and
    2) moving all logic to ensure that the {src} register is usable before
       the switch, such that it's shared by all the compare-exchange cases.
    
    As a side produce, this also fixes issue 1045225, because for i64 stores
    which actually only use the lower half of {src}, only that half will be
    pinned.
    
    R=ahaas@chromium.org
    
    Bug: chromium:1045225, v8:10108
    Change-Id: I0be025b9706d563835ae6337d45b88e0233eacad
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2029414Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66062}
    d8bb229d
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DEPS Loading commit data...
liftoff-assembler-defs.h Loading commit data...
liftoff-assembler.cc Loading commit data...
liftoff-assembler.h Loading commit data...
liftoff-compiler.cc Loading commit data...
liftoff-compiler.h Loading commit data...
liftoff-register.h Loading commit data...