• Tobias Tebbi's avatar
    Reland^6 "[turbofan] eagerly prune None types and deadness from the graph" · 19ac10e5
    Tobias Tebbi authored
    Reland of https://chromium-review.googlesource.com/c/v8/v8/+/727893
    The crashes should be fixed by https://chromium-review.googlesource.com/c/v8/v8/+/763531
    
    Original change's description:
    > Revert "Reland^5 "[turbofan] eagerly prune None types and deadness from the graph""
    > 
    > This reverts commit ac0661b3.
    > 
    > Reason for revert: Clusterfuzz unhappy: chromium:783019 chromium:783035
    > 
    > Original change's description:
    > > Reland^5 "[turbofan] eagerly prune None types and deadness from the graph"
    > >
    > > This gives up on earlier attempts to interpret DeadValue as a signal of
    > > unreachable code. This does not work because free-floating dead value
    > > nodes, and even pure branch nodes that use them, can get scheduled so
    > > early that they get reachable. Instead, we now eagerly remove branches
    > > that use DeadValue in DeadCodeElimination and replace DeadValue inputs
    > > to value phi nodes with dummy values.
    > >
    > > Reland of https://chromium-review.googlesource.com/715716
    > >
    > > Bug: chromium:741225 chromium:776256
    > > Change-Id: I251efd507c967d4a8882ad8fd2fd96c4185781fe
    > > Reviewed-on: https://chromium-review.googlesource.com/727893
    > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#49188}
    > 
    > TBR=jarin@chromium.org,tebbi@chromium.org
    > 
    > Bug: chromium:741225 chromium:776256 chromium:783019 chromium:783035
    > Change-Id: I6a8fa3a08ce2824a858ae01817688e63ed1f442e
    > Reviewed-on: https://chromium-review.googlesource.com/758770
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#49262}
    
    TBR=jarin@chromium.org,tebbi@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:741225 chromium:776256 chromium:783019 chromium:783035
    Change-Id: I6c02b4beb02997ec34015ed2f6791a93c70f5e36
    Reviewed-on: https://chromium-review.googlesource.com/772150
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49429}
    19ac10e5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...