• Clemens Hammacher's avatar
    Revert "[wasm] Don't store global handles in the interpreter" · 199a26f7
    Clemens Hammacher authored
    This reverts commit 5648aad5.
    
    Reason for revert: Compile error on mips:
    https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/10732
    
    Original change's description:
    > [wasm] Don't store global handles in the interpreter
    > 
    > Storing global handles in the interpreter is dangerous, because the
    > global handles are strong roots into the heap. The interpreter itself is
    > referenced from the heap via a Managed. Hence the interpreter keeps the
    > instance alive, while the instance keeps the Managed alive. So the GC
    > will never collect them.
    > 
    > This CL refactors this to only store the handle to the instance object
    > while executing in the interpreter, and clearing it when returning.
    > It also removes the cache of import wrappers, as it should not be
    > performance critical, but keeps lots of objects alive. If it turns out
    > to be performance critical, we will have to reintroduce such a cache
    > stored in the WasmDebugInfo object.
    > 
    > R=​titzer@chromium.org
    > CC=ahaas@chromium.org
    > 
    > Bug: chromium:610330
    > Change-Id: I54b489dadc16685887c0c1a98da6fd0df5ad7cbb
    > Reviewed-on: https://chromium-review.googlesource.com/567058
    > Reviewed-by: Ben Titzer <titzer@chromium.org>
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#46629}
    
    TBR=titzer@chromium.org,clemensh@chromium.org
    
    Change-Id: Ifadfb885f937f37bb3eab4732a97f20ff40c2583
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:610330
    Reviewed-on: https://chromium-review.googlesource.com/569962Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46630}
    199a26f7
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...