• Caitlin Potter's avatar
    [js-perf-test] add microbenchmarks for (Object|Reflect).getOwnPropertyDescriptor · 190128ce
    Caitlin Potter authored
    Based on the robust test suite for checking property "has/in" queries, with the intention
    of measuring the performance of accessing getOwnPropertyDescriptor.
    
    Background: getOwnPropertyDescriptor and defineProperty were identified as hot code taking up
    a significant chunk of startup time in a customer application. This benchmark aims to measure
    the difference made by a modifying Object.getOwnPropertyDescriptor.
    
    By current measurements, the geometric mean time of the new version is typically 1/6 that of
    the current upstream implementation, using this test specifically (however, only on arm64 /
    Apple M1... On Linux/x64, the results look more reasonable at a roughly 5-12% improvement in
    score).
    
    In its current form, this benchmark does very little to attempt to verify the results of the
    object, which may result in branches being discarded in Turbofan (but given the enormous
    difference between x64 and arm64, I'm not positive this is what is happening, and have not yet
    verified this).
    
    BUG=
    
    Change-Id: I0f10735315313ed97efd00fcccaedc1272d4d314
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3624979
    Commit-Queue: Caitlin Potter <caitp@igalia.com>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80373}
    190128ce
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...