• Samuel Groß's avatar
    Add PageInitializationMode enum for the BoundedPageAllocator · 18c37d32
    Samuel Groß authored
    Currently, when compiling with V8_VIRTUAL_MEMORY_CAGE enabled, the
    behavior of the BoundedPageAllocator changes from simply making freed
    pages inaccessible to decommitting them, which guarantees that they will
    be zero-initialized after the next allocation. As this seems to cause
    some performance regressions on Mac, this CL introduces a new enum that
    specifies how the allocator should behave:
    kAllocatedPagesMustBeZeroInitialized causes the pages to be decommitted
    during FreePages() and ReleasePages() and thus guarantees
    zero-initialization during AllocPages().
    kAllocatedPagesCanBeUninitialized only causes the pages to be made
    inaccessible, and so does not generally guarantee zero-initialization
    for AllocPages().
    
    Finally, this CL also removes some dead code in allocation.cc.
    
    Bug: chromium:1257089
    Change-Id: I53fa52c8913df869bee2b536efe252780d1ad893
    Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208812
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77285}
    18c37d32
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...