• kozyatinskiy's avatar
    [inspector] removed kDebugPromiseCollected event · 189ffd94
    kozyatinskiy authored
    With recent CLs we always store maximum N async stack traces and when we reach limit we drop half of them.
    Current promise collected event requires creating weak handle:
    - it takes time,
    - it consumes memory.
    Since async task id distribution for promises is uniform (each new promise has last_async_task_id + 1 as an id) our hash map is good enough to handle any amount of async task ids, following time of executing 1 000 000 000 of lookups:
    - for empty hash map: 1.45 seconds,
    - for hash map with one entry: 14.95 seconds
    - 1024 entries: 15.03 seconds
    - 1024 * 1024 entries: 14.82 seconds
    - 1024 * 1024 * 1024: 17.9 seconds
    
    BUG=v8:6189
    R=dgozman@chromium.org,yangguo@chromium.org
    
    Review-Url: https://codereview.chromium.org/2819423005
    Cr-Commit-Position: refs/heads/master@{#44750}
    189ffd94
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...