• Milad Fa's avatar
    Fix Wasm atomic waits on big endian platforms · 183a2abc
    Milad Fa authored
    Wasm values are stored in memory in little endian order even
    on BE machines and as a result they need to be manually reversed
    after a load.
    
    Other such atomic ops get patched during Wasm compilation or
    during code-gen, this is one of the few places where a runtime call is
    made to C++ which requires this fix.
    
    As the the runtime stub is used on both TurboFan and Liftoff this
    patch will fix both cases.
    
    Up until now the cctest was passing incorrectly as it's mixing the
    Wasm memory buffer with TypedArrays. TypedArrays don't have the
    LE enforcement and use the native byte order.
    
    With this patch the test is now failing as expected
    and is being skipped for now.
    
    Bug: v8:12505
    Change-Id: I49fac208f1fab7396b7d9911e803bc047b3b8263
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350744Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/main@{#78433}
    183a2abc
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...