• Milad Fa's avatar
    Fix Wasm atomic waits on big endian platforms · 183a2abc
    Milad Fa authored
    Wasm values are stored in memory in little endian order even
    on BE machines and as a result they need to be manually reversed
    after a load.
    
    Other such atomic ops get patched during Wasm compilation or
    during code-gen, this is one of the few places where a runtime call is
    made to C++ which requires this fix.
    
    As the the runtime stub is used on both TurboFan and Liftoff this
    patch will fix both cases.
    
    Up until now the cctest was passing incorrectly as it's mixing the
    Wasm memory buffer with TypedArrays. TypedArrays don't have the
    LE enforcement and use the native byte order.
    
    With this patch the test is now failing as expected
    and is being skipped for now.
    
    Bug: v8:12505
    Change-Id: I49fac208f1fab7396b7d9911e803bc047b3b8263
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350744Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/main@{#78433}
    183a2abc
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...