• Ben Smith's avatar
    Add TSAN annotations for TypedArray accesses · 181c03e9
    Ben Smith authored
    TSAN finds data races in generated JavaScript code that use
    access the SharedArrayBuffer backing store racily. These are races, but
    they are OK in the sense that the JavaScript memory model allows for the
    potential bad behavior they could introduce (e.g. potentially tearing
    reads). Relaxed atomics could be used here instead, but that could
    introduce performance regressions.
    
    This change adds TSAN annotations to the TypedArray reads/writes to
    prevent TSAN from warning about them.
    
    Bug: chromium:722871
    Change-Id: I0776475f02a352b678ade7d32ed6bd4a6be98c36
    Reviewed-on: https://chromium-review.googlesource.com/656509
    Commit-Queue: Ben Smith <binji@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47929}
    181c03e9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...