• binji's avatar
    d8: Leak context_mutex_ so it will never be destroyed while locked · 162f116a
    binji authored
    Calling quit() from d8 will call exit(), which will run static destructors. If
    context_mutex_ is statically allocated, pthread_mutex_destroy will be called.
    
    When running d8 in "isolates" mode, another thread may be running. If it calls
    CreateEvaluationContext, it will lock the context_mutex_. If the mutex is
    destroyed while it is locked, it will return an error.
    
    This CL changes the Mutex to a LazyMutex, which will leak instead of being
    destroyed.
    
    BUG=v8:4279
    R=jarin@chromium.org
    R=machenbach@chromium.org
    LOG=n
    
    Review URL: https://codereview.chromium.org/1240553003
    
    Cr-Commit-Position: refs/heads/master@{#29709}
    162f116a
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...