• Leszek Swirski's avatar
    [compiler-dispatcher] Port to Jobs API · 15b1ce39
    Leszek Swirski authored
    Port the CompilerDispatcher to use the Jobs API, instead of its own
    hand-rolled worker management.
    
    This required some re-thinking of how testing is handled, since the
    tests want to be able to
    
      a) Defer calls to PostTask/Job, to actuall post the jobs later. This
         was easy enough with PostTask, since we could simply store the task
         in a list and no-op, but PostJob has to return a JobHandle. The
         tests now have a DelayedJobHandleWrapper, which defers all method
         calls on itself, and because of all the unique_ptrs, there's also
         now a SharedJobHandleWrapper.
    
      b) Wait until tasks/jobs complete. Returning from a Task meant that
         the task had completed, but this isn't necessarily the case with
         JobTasks; e.g. a job might be asked to yield. This patch hacks
         around this by Posting and Joining a non-owning copy of the
         requested JobTask, and then re-posting it once Join returns.
    
    Change-Id: If867b4122af52758ffabcfb78a6701f0f95d896d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563664
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77618}
    15b1ce39
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...