• Sigurd Schneider's avatar
    Revert "[parsing] inline ArrayLiteral creation for spread calls" · f48e7349
    Sigurd Schneider authored
    This reverts commit 93fc3841.
    
    Reason for revert: may break node.js integration
    
    Original change's description:
    > [parsing] inline ArrayLiteral creation for spread calls
    > 
    > Instead of using runtime calls to generate the Array Literal passed to
    > %reflect_call / %reflect_construct, we create an ArrayLiteral from the
    > list of arguments, and perform spreads using the interpreter mechanism for
    > spreading in ArrayLiterals (thus, the spreading becomes inline). This
    > array literal is still passed to %reflect_call / %reflect_construct as
    > before.
    > 
    > This cuts the runtime for bench-spread-call.js -> testSpread roughly in
    > half, and will likely improve further once
    > https://chromium-review.googlesource.com/c/v8/v8/+/915364 has landed.
    > 
    > BUG=v8:7446
    > R=​neis@chromium.org, adamk@chromium.org
    > 
    > Change-Id: I74a6acd3a60aad422e4ac575275c7b567659d8ad
    > Reviewed-on: https://chromium-review.googlesource.com/939587
    > Commit-Queue: Georg Neis <neis@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#51678}
    
    TBR=adamk@chromium.org,neis@chromium.org,caitp@igalia.com,bmeurer@chromium.org
    
    Change-Id: I4730077591bce0e5e7b2ce7d59678e8b7135cc08
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7446
    Reviewed-on: https://chromium-review.googlesource.com/945769Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51682}
    f48e7349
Name
Last commit
Last update
..
OWNERS Loading commit data...
array.js Loading commit data...
intl.js Loading commit data...
macros.py Loading commit data...
messages.js Loading commit data...
prologue.js Loading commit data...
spread.js Loading commit data...
typedarray.js Loading commit data...