• Clemens Hammacher's avatar
    [Liftoff] Fix moving stack values · 14faced4
    Clemens Hammacher authored
    On x64 the {kScratchRegister} cannot be held in a {LiftoffRegister},
    since it is not a valid cache register. Also, the code unnecessarily
    checked whether there is an unused cache register, but then didn't use
    it. Simplify the logic to always use the scratch register, just
    distinguish between 4-byte and 8-byte moves.
    On ia32 we did not move 64-bit values correctly if we didn't have
    unused registers and needed to move via the stack.
    
    R=titzer@chromium.org
    
    Bug: v8:6600, chromium:917588, chromium:917450
    Change-Id: I0bbe946c6ac8fca62f85711ae47afdac9c02ae6b
    Reviewed-on: https://chromium-review.googlesource.com/c/1391755Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58521}
    14faced4
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...