• Frank Tang's avatar
    Reland "[Temporal] Use double/int32_t instead of int64_t for duration parsing" · 14d9b9a2
    Frank Tang authored
    This is a reland of commit a165e82e
    
    The reason of revert is  SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../src/objects/js-temporal-objects.cc:3837:22   which is the line
    "nanoseconds_mv = std::round((seconds_mv - std::floor(seconds_mv)) * 1e9);"
    where seconds_mv is a double and nanoseconds_mv is a int32_t
    In this reland, we change the type of nanoseconds_mv to double to avoid the ubsan error.
    
    
    Original change's description:
    > [Temporal] Use double/int32_t instead of int64_t for duration parsing
    >
    > Use double and int32_t instead of int64_t in duration parsing result
    > so we can parse very large duration fields as infinity and throw RangeError in later stages. The three fractional parts can hold up value from 0 to 999,999,999 so we use int32_t to hold it. Other part could be infinity so we use double to hold it. Also rearrange the order of the three int32_t in the struct ParsedISO8601Duration after all the double
    >
    > Bug: v8:11544
    > Change-Id: I7e5b02f7c7bbb60997f1419f016aed61dd3e0d6c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3840761
    > Reviewed-by: Shu-yu Guo <syg@chromium.org>
    > Commit-Queue: Frank Tang <ftang@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82754}
    
    Bug: v8:11544
    Change-Id: If8b72cb4912d8b4fc4c286fc856ea59df5cf0bb7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858576Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83090}
    14d9b9a2
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...