• Clemens Backes's avatar
    Revert "[wasm] Prevent breakpoints on nonbreakable positions" · d1462a56
    Clemens Backes authored
    This reverts commit 3c98a2a3.
    
    Reason for revert: Fails on arm: https://ci.chromium.org/p/v8/builders/ci/V8%20Arm%20-%20debug/12134
    
    Original change's description:
    > [wasm] Prevent breakpoints on nonbreakable positions
    > 
    > If a breakpoint is set on a non-breakable position, the wasm interpreter
    > just stores the value 0xFF (kInternalBreakpoint) in the function body
    > (actually, a copy of the function body). This might overwrite immediates
    > and cause subsequent failures in the wasm interpreter.
    > 
    > In JavaScript, breakpoints are just forwarded to the next breakable
    > position. This CL implements the same for WebAssembly.
    > A cctest tests this behavior, and the existing
    > wasm-stepping-byte-offsets.js inspector test is extended to also set the
    > breakpoint within an i32 constant immediate.
    > 
    > R=​leese@chromium.org, mstarzinger@chromium.org
    > CC=​​bmeurer@chromium.org
    > 
    > Bug: chromium:1025184
    > Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65070}
    
    TBR=mstarzinger@chromium.org,clemensb@chromium.org,bmeurer@chromium.org,leese@chromium.org
    
    Change-Id: I7468ea3b15fecccdea521308325cf4851e0a0396
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:1025184
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926032Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65074}
    d1462a56
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...