• Jon Kunkee's avatar
    fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references · 13a04aba
    Jon Kunkee authored
    This change fixes missing symbol errors in the Windows 10 on ARM build
    of Node.js.
    
    When a whole class is marked for export, all of its members are marked
    as well. This can be a problem when inline members call undefined yet
    inline members of other classes: the exported function will contain a
    reference to the undefined inline function that should be satisfied at
    link time, but because the other function is inline no symbol will be
    produced that will satisfy that reference.
    
    Clang gets around this by masking inlined class members from export
    using /Fc:dllexportInlines-. This is why b0a2a567 worked.
    
    Node.js' Windows builds use MSVC and so do not have access to this
    flag. This results in unresolved symbols at link time.
    
    Bug: v8:9465
    Change-Id: Ief9c7ab6ba35d22f995939eb62a64d6f1992ed85
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696771Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62660}
    13a04aba
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...