• Jon Kunkee's avatar
    fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references · 13a04aba
    Jon Kunkee authored
    This change fixes missing symbol errors in the Windows 10 on ARM build
    of Node.js.
    
    When a whole class is marked for export, all of its members are marked
    as well. This can be a problem when inline members call undefined yet
    inline members of other classes: the exported function will contain a
    reference to the undefined inline function that should be satisfied at
    link time, but because the other function is inline no symbol will be
    produced that will satisfy that reference.
    
    Clang gets around this by masking inlined class members from export
    using /Fc:dllexportInlines-. This is why b0a2a567 worked.
    
    Node.js' Windows builds use MSVC and so do not have access to this
    flag. This results in unresolved symbols at link time.
    
    Bug: v8:9465
    Change-Id: Ief9c7ab6ba35d22f995939eb62a64d6f1992ed85
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1696771Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62660}
    13a04aba
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...