• Marja Hölttä's avatar
    [parser] Fix arrow funcs w/ destructuring params again. [Alternative fix] · 138fbdb4
    Marja Hölttä authored
    What happened:
    - When rewriting in DoParseFunction, the relevant function scope is no longer in
    the scope stack.
    - The correct scope is given to the PatternRewriter.
    - PatternRewriter called to Parser::BuildIteratorCloseForCompletion.
    - BuildIteratorCloseForCompletion would just call NewTemporary (which creates
    a new temporary in Parser's current scope) instead of using the scope passed to
    it and calling NewTemporary on it.
    - Normally this went unnoticed, since it doesn't matter that much where the
    temporary is.
    - But in the lazy arrow func case, the Parser's scope at that point was the
    already-resolved outer scope, and a DCHECK detected this problem.
    
    Kudos & thanks to verwaest@ for a debugging session :)
    
    BUG=chromium:761831
    
    Change-Id: I1e8474ce927be0330f4ba4efc0fc08fdcc328809
    Reviewed-on: https://chromium-review.googlesource.com/650297
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47877}
    138fbdb4
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...