• Joey Gouly's avatar
    Reland "[liftoff] Introduce emit_{i64,i32}_add with immediate" · 138d2dfc
    Joey Gouly authored
    This is a reland of e3be96d6
    
    The failure was due to not sign extendint the immediate for 64-bit adds on
    32-bit platforms.
    
    Original change's description:
    > [liftoff] Introduce emit_{i64,i32}_add with immediate
    >
    > This allows immediates to be encoded directly into instructions, rather than
    > mov-ing constants to registers first.
    >
    > This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once
    > this approach has been approved.
    >
    > Bug: v8:9038
    >
    > Change-Id: I0c7306c2da0dae26f1c6e2465a9565adbf0bda84
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524482
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#60506}
    
    Bug: v8:9038
    Change-Id: I7dd1112827d037d900fd36cce71206388642605b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543730Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60521}
    138d2dfc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...