-
Dan Elphick authored
Due to some unusual build failures on some trybots, v8_generate_external_defines_header was reverted to false. This turns it back on but changes the behaviour so that defines are added to the command line as well as to the header. Because the generated header checks that flags that should be unset are actually unset and flags that should be set are either unset or set to 1, this will cause build failures on many types of mismatches, although it will not detect where a flag is not set on the command line when it is set by the header. If no further failures show up with this, the hybrid part can be removed and the v8-gn.h header can stand on its own. Bug: v8:11292, v8:11341 Change-Id: I1deeeebec58f79607e68a28f808649e884810923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649041 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72327}
1370b29e