• Benedikt Meurer's avatar
    [collections] Refactor map entry lookup and make naming more consistent. · 130cee39
    Benedikt Meurer authored
    Rename the MapLookupHashIndex builtin to FindOrderedHashMapEntry and
    also rename the TurboFan operators LookupHashStorageIndex and
    LookupSigned32HashStorageIndex to FindOrderedHashMapEntry and
    FindOrderedHashMapEntryForInt32Key respectively. This way the naming is
    more consistent and it's immediately obvious from the operator name that
    this operator deals with OrderedHashMaps, which wasn't clear before.
    
    Also fix the result of the operation to be either -1 or the index of
    the entry relative to the hash table start (that is, no longer eagerly
    add hash table start plus value offset to the entry index). This removes
    this non-foldable integer additon from TurboFan code for both Map#get
    and Map#has.
    
    Drive-by-fix: Also provide more concrete types for the
    FindOrderedHashMapEntry operators.
    
    Bug: v8:5049
    Change-Id: I418d107b806f3031a52a525cffc20456dc2342db
    Reviewed-on: https://chromium-review.googlesource.com/707414Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48404}
    130cee39
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...